Add support for configuring backpressure #14
Conversation
gjcairo
force-pushed
the
backpressure
branch
from
9dbd727 to
2b889f2
Compare
| } | ||
|
|
||
| /// No backpressure will be applied to reading requests or writing responses. | ||
| public static let none: Self = .init(backing: .none) |
There was a problem hiding this comment.
When is this an acceptable choice?
There was a problem hiding this comment.
Arguably never at least in production services but I thought it made sense to still offer it? I can get rid of it.
There was a problem hiding this comment.
The underlying async channel doesn’t even offer that
There was a problem hiding this comment.
Yeah, we don't need to offer things that nobody should ever use.
gjcairo
force-pushed
the
backpressure
branch
from
2b889f2 to
4424950
Compare
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
I approve this for now but I'm wondering how useful just this setting is since it only applies to the outmost AsyncChannel for the request/responses. There are a few more in play here though. Let's move forward but we might want to expose more configuration here for the various bits over time.
gjcairo
force-pushed
the
backpressure
branch
from
4424950 to
5ee4044
Compare
|
For the record:
|
No description provided.